Merged
Conversation
StephenPasteris
force-pushed
the
sequence_form
branch
from
3d23aea to
739eca7
Compare
tturocy
requested changes
Nov 11, 2025
Makefile.am
Outdated
| src/gambit.h \ | ||
| src/games/gameseq.cc \ | ||
| src/games/gameseq.h \ | ||
| src/games/indexproduct.h \ |
Member
There was a problem hiding this comment.
We can just leave indexproduct.h in enumpoly.
src/games/behavspt.cc
Outdated
|
|
||
| SequencesWrapper BehaviorSupportProfile::GetSequences() const | ||
| { | ||
| auto sequences = GetSequenceForm()->GetSequences(); |
Member
There was a problem hiding this comment.
Can we get by with these being one-liners rather than defining the variable?
src/games/behavspt.h
Outdated
| namespace Gambit { | ||
|
|
||
| class GameSequenceForm; | ||
| struct GameSequenceRep; |
Member
There was a problem hiding this comment.
GameSequenceRep should be a class (it'll be used as one in later development)
Member
There was a problem hiding this comment.
The conceptual model for sequences is very similar to that for strategies (in terms of how we represent them, generate them on demand, and so on). So we want to evolve sequences in that direction.
Member
There was a problem hiding this comment.
Let's make the GameSequenceRep members private now as a step in this direction.
tturocy
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #593